Re: [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible string

From: Krzysztof Kozlowski
Date: Tue Aug 30 2022 - 05:51:43 EST


On 29/08/2022 09:50, Anand Moon wrote:
> Add compatible string for RV1126 gmac, and constrain it to
> be compatible with Synopsys dwmac 4.20a.
>
> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxx>
> Signed-off-by: Anand Moon <anand@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index 083623c8d718..346e248a6ba5 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> @@ -26,6 +26,7 @@ select:
> - rockchip,rk3399-gmac
> - rockchip,rk3568-gmac
> - rockchip,rv1108-gmac
> + - rockchip,rv1126-gmac

That's not a complete change. What about the other place listing
compatibles? Did you test the bindings on your DTS?

Best regards,
Krzysztof