Re: [PATCH 10/11] dt-bindings: PCI: qcom-ep: Add support for SM8450 SoC
From: Manivannan Sadhasivam
Date: Tue Aug 30 2022 - 07:57:37 EST
On Sun, Aug 28, 2022 at 06:17:43PM +0300, Krzysztof Kozlowski wrote:
> On 26/08/2022 21:19, Manivannan Sadhasivam wrote:
> > Add devicetree bindings support for SM8450 SoC. Only the clocks are
> > different on this platform, rest is same as SDX55.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > ---
> > .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 27 +++++++++++++++++--
> > 1 file changed, 25 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > index 83a2cfc63bc1..9914d575ec41 100644
> > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > @@ -12,6 +12,7 @@ maintainers:
> > properties:
> > compatible:
> > const: qcom,sdx55-pcie-ep
> > + const: qcom,sm8450-pcie-ep
>
> You need to test the bindings with `make dt_binding_check`. This
> requires an enum instead of two consts.
Sorry! Usually I do but somehow missed on this series.
Thanks,
Mani
>
>
> Best regards,
> Krzysztof
--
மணிவண்ணன் சதாசிவம்