Re: [PATCH v5 1/2] dts: arm: Adding documentation for SAMA5D3-EDS board

From: Krzysztof Kozlowski
Date: Tue Aug 30 2022 - 12:57:22 EST


On 30/08/2022 18:24, Jerry Ray wrote:
> Adding the SAMA5D3-EDS board from Microchip into the atmel AT91 board
> description yaml file.
>
> Signed-off-by: Jerry Ray <jerry.ray@xxxxxxxxxxxxx>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> ---

Use subject prefixes matching the subsystem (git log --oneline -- ...).

> v4->v5:
> - No change
> v3->v4:
> - No change
> v2->v3:
> - No change
> v1->v2:
> - Added Device Tree documentation for Microchip SAMA5D3-EDS board
> ---
> Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index 08efb259a947..635491aaeb0c 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -138,6 +138,13 @@ properties:
> - const: atmel,at91sam9g20
> - const: atmel,at91sam9
>
> + - description: Microchip SAMA5D3 Ethernet Development System Board
> + items:
> + - const: microchip,sama5d3-eds
> + - const: atmel,sama5d36

This does not match your DTS.

Test your bindings...

Please drop Rob's ack as this is not correct.

Best regards,
Krzysztof