RE: [EXT] Re: [PATCH v1 1/1] usb: phy: mxs: apply board calibration value base on chip trim value

[Frank Li]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Tuesday, August 30, 2022 12:33 PM
> To: Frank Li <frank.li@xxxxxxx>; kishon@xxxxxx; vkoul@xxxxxxxxxx;
> robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; balbi@xxxxxxxxxx;
> gregkh@xxxxxxxxxxxxxxxxxxx; linux-phy@xxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v1 1/1] usb: phy: mxs: apply board calibration
> value base on chip trim value
> 
> Caution: EXT Email
> 
> On 30/08/2022 19:25, Frank Li wrote:
> > USBPHY_TRIM_OVERRIDE provide chip trim value. DTS provide board level
> > calibration data. Board level calibration data should be base on chip
> > trim value.
> >
> > For example, TXCAL45DP board level hope add +2.85% register base on
> > standard 45ohm. But chip trim value is -5.25% to get 45ohm output.
> > Actually finial TXCAL45DP should be -5.25% + 2.85% = -2.4%.
> >
> > If chip have not trim value at USBPHY_TRIM_OVERRIDE, No behavior
> change.
> > board level calibration will be applied.
> >
> > If chip have trim value at USBPHY_TRIM_OVERRIDE and no DTS board level
> > data, chip trim value will be applied.
> >
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> >  drivers/usb/phy/phy-mxs-usb.c | 40
> ++++++++++++++++++++++++++++++++---
> >  1 file changed, 37 insertions(+), 3 deletions(-)
> 
> Use scripts/get_maintainers.pl to CC all maintainers and relevant
> mailing lists.... and do not Cc unrelated folks.

[Frank Li] Thanks. I reused cc list,  I sent the patch yesterday, which change the same file.
Only difference,  This patch have not touch document. 
Next time, I will rerun get_mainainers.pl.

> 
> Best regards,
> Krzysztof