Re: [PATCH v1 0/8] gpio: Get rid of ARCH_NR_GPIOS (v1)

From: Andy Shevchenko
Date: Tue Aug 30 2022 - 16:22:01 EST


On Tue, Aug 30, 2022 at 11:20 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Mon, Aug 29, 2022 at 7:17 PM Christophe Leroy
> <christophe.leroy@xxxxxxxxxx> wrote:
> >
> > Since commit 14e85c0e69d5 ("gpio: remove gpio_descs global array")
> > there is no limitation on the number of GPIOs that can be allocated
> > in the system since the allocation is fully dynamic.
> >
> > ARCH_NR_GPIOS is today only used in order to provide downwards
> > gpiobase allocation from that value, while static allocation is
> > performed upwards from 0. However that has the disadvantage of
> > limiting the number of GPIOs that can be registered in the system.
> >
> > To overcome this limitation without requiring each and every
> > platform to provide its 'best-guess' maximum number, rework the
> > allocation to allocate from 256 upwards, allowing approx 2 millions
> > of GPIOs.
> >
> > In the meantime, add a warning for drivers how are still doing
> > static allocation, so that in the future the static allocation gets
> > removed completely and dynamic allocation can start at base 0.
>
> For non-commented (by me or others) patches
> Reviewed-by: Andy Shevchenko <andy.shevchenko!gmail.com>

Should be
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> For the patch 1 if you are going to address as suggested by the author
> of the driver, you may also add my tag.



--
With Best Regards,
Andy Shevchenko