Re: [PATCH] dt-bindings: nvmem: u-boot,env: add basic NVMEM cells

From: Tom Rini
Date: Tue Aug 30 2022 - 17:11:47 EST


On Tue, Aug 16, 2022 at 11:26:37AM +0200, Rafał Miłecki wrote:
> On 3.07.2022 10:48, Rafał Miłecki wrote:
> > U-Boot doesn't have cells at hardcoded addresses. They are stored in
> > internal format. It's still important to define relevant cells in DT so
> > NVMEM consumers can reference them.
> >
> > Update binding to allow including basic cells as NVMEM device subnodes.
>
> Ping :)
>
>
> For a reference you can see Broadcom's NVRAM (identical feature):
>
> 084973e944bec ("dt-bindings: nvmem: brcm,nvram: add basic NVMEM cells")
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=084973e944bec21804f8afb0515b25434438699a
>
> c8442f0fb09ca ("ARM: dts: BCM5301X: Add Ethernet MAC address to Luxul XWR-3150")
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c8442f0fb09ca3d842b9b23d1d0650f649fd10f8

Seems fine to me.

Reviewed-by: Tom Rini <trini@xxxxxxxxxxxx>

--
Tom

Attachment: signature.asc
Description: PGP signature