Re: [PATCH] KVM/VMX: Avoid stack engine synchronization uop in __vmx_vcpu_run

From: Sean Christopherson
Date: Tue Aug 30 2022 - 17:44:03 EST


On Tue, Aug 16, 2022, Uros Bizjak wrote:
> Avoid instructions with explicit uses of the stack pointer between
> instructions that implicitly refer to it. The sequence of
> POP %reg; ADD $x, %RSP; POP %reg forces emission of synchronization
> uop to synchronize the value of the stack pointer in the stack engine
> and the out-of-order core.
>
> Using POP with the dummy register instead of ADD $x, %RSP results in a
> smaller code size and faster code.
>
> The patch also fixes the reference to the wrong register in the
> nearby comment.
>
> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Cc: Sean Christopherson <seanjc@xxxxxxxxxx>
> Signed-off-by: Uros Bizjak <ubizjak@xxxxxxxxx>
> ---

Pushed to branch `for_paolo/6.1` at:

https://github.com/sean-jc/linux.git

Unless you hear otherwise, it will make its way to kvm/queue "soon".

Note, the commit IDs are not guaranteed to be stable.