Re: [PATCH 6/7] binder: fix binder_alloc kernel-doc warnings

From: Todd Kjos
Date: Tue Aug 30 2022 - 18:25:36 EST


On Mon, Aug 29, 2022 at 1:13 PM 'Carlos Llamas' via kernel-team
<kernel-team@xxxxxxxxxxx> wrote:
>
> Update the kernel-doc section of struct binder_alloc to fix the
> following warnings reported by ./scripts/kernel-doc:
>
> warning: Function parameter or member 'mutex' not described in 'binder_alloc'
> warning: Function parameter or member 'vma_addr' not described in 'binder_alloc'
>
> No functional changes in this patch.
>
> Signed-off-by: Carlos Llamas <cmllamas@xxxxxxxxxx>

Acked-by: Todd Kjos <tkjos@xxxxxxxxxx>

> ---
> drivers/android/binder_alloc.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/android/binder_alloc.h b/drivers/android/binder_alloc.h
> index ab3b027bcd29..0f811ac4bcff 100644
> --- a/drivers/android/binder_alloc.h
> +++ b/drivers/android/binder_alloc.h
> @@ -74,10 +74,9 @@ struct binder_lru_page {
>
> /**
> * struct binder_alloc - per-binder proc state for binder allocator
> - * @vma: vm_area_struct passed to mmap_handler
> + * @mutex: protects binder_alloc fields
> + * @vma_addr: vm_area_struct->vm_start passed to mmap_handler
> * (invariant after mmap)
> - * @tsk: tid for task that called init for this proc
> - * (invariant after init)
> * @mm: copy of task->mm (invariant after open)
> * @buffer: base of per-proc address space mapped via mmap
> * @buffers: list of all buffers for this proc
> --
> 2.37.2.672.g94769d06f0-goog
>
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@xxxxxxxxxxx.
>