Re: [RESEND PATCH v2 4/5] firmware: qcom: scm: Add wait-queue helper functions
From: kernel test robot
Date: Tue Aug 30 2022 - 20:32:50 EST
Hi Guru,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20220830]
[cannot apply to robh/for-next linus/master v6.0-rc3 v6.0-rc2 v6.0-rc1 v6.0-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Guru-Das-Srinagesh/SCM-Add-support-for-wait-queue-aware-firmware/20220831-063013
base: 282342f2dc97ccf54254c5de51bcc1101229615f
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220831/202208310849.pEettWuy-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/ad41ee028d07c3e3e41b15e6bd8e2985f30df508
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Guru-Das-Srinagesh/SCM-Add-support-for-wait-queue-aware-firmware/20220831-063013
git checkout ad41ee028d07c3e3e41b15e6bd8e2985f30df508
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/firmware/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
In file included from include/linux/string.h:20,
from include/linux/bitmap.h:11,
from include/linux/cpumask.h:12,
from include/linux/smp.h:13,
from include/linux/lockdep.h:14,
from include/linux/spinlock.h:62,
from include/linux/mmzone.h:8,
from arch/m68k/include/asm/virtconvert.h:12,
from arch/m68k/include/asm/io_mm.h:26,
from arch/m68k/include/asm/io.h:8,
from include/linux/io.h:13,
from drivers/firmware/qcom_scm-smc.c:6:
drivers/firmware/qcom_scm-smc.c: In function 'fill_wq_resume_args':
>> arch/m68k/include/asm/string.h:68:25: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
68 | #define memset(d, c, n) __builtin_memset(d, c, n)
| ^~~~~~~~~~~~~~~~
drivers/firmware/qcom_scm-smc.c:58:9: note: in expansion of macro 'memset'
58 | memset(resume->args, 0, ARRAY_SIZE(resume->args));
| ^~~~~~
drivers/firmware/qcom_scm-smc.c: In function 'fill_wq_wake_ack_args':
>> arch/m68k/include/asm/string.h:68:25: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
68 | #define memset(d, c, n) __builtin_memset(d, c, n)
| ^~~~~~~~~~~~~~~~
drivers/firmware/qcom_scm-smc.c:71:9: note: in expansion of macro 'memset'
71 | memset(wake_ack->args, 0, ARRAY_SIZE(wake_ack->args));
| ^~~~~~
drivers/firmware/qcom_scm-smc.c: In function 'fill_get_wq_ctx_args':
>> arch/m68k/include/asm/string.h:68:25: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
68 | #define memset(d, c, n) __builtin_memset(d, c, n)
| ^~~~~~~~~~~~~~~~
drivers/firmware/qcom_scm-smc.c:84:9: note: in expansion of macro 'memset'
84 | memset(get_wq_ctx->args, 0, ARRAY_SIZE(get_wq_ctx->args));
| ^~~~~~
drivers/firmware/qcom_scm-smc.c: At top level:
drivers/firmware/qcom_scm-smc.c:69:13: warning: 'fill_wq_wake_ack_args' defined but not used [-Wunused-function]
69 | static void fill_wq_wake_ack_args(struct arm_smccc_args *wake_ack, u32 smc_call_ctx)
| ^~~~~~~~~~~~~~~~~~~~~
drivers/firmware/qcom_scm-smc.c:56:13: warning: 'fill_wq_resume_args' defined but not used [-Wunused-function]
56 | static void fill_wq_resume_args(struct arm_smccc_args *resume, u32 smc_call_ctx)
| ^~~~~~~~~~~~~~~~~~~
vim +/memset +68 arch/m68k/include/asm/string.h
ea61bc461d09e8 Greg Ungerer 2010-09-07 65
ea61bc461d09e8 Greg Ungerer 2010-09-07 66 #define __HAVE_ARCH_MEMSET
ea61bc461d09e8 Greg Ungerer 2010-09-07 67 extern void *memset(void *, int, __kernel_size_t);
ea61bc461d09e8 Greg Ungerer 2010-09-07 @68 #define memset(d, c, n) __builtin_memset(d, c, n)
ea61bc461d09e8 Greg Ungerer 2010-09-07 69
--
0-DAY CI Kernel Test Service
https://01.org/lkp