Re: [PATCH v1 2/5] arm64: dts: imx8mq-librem5: add RGB pwmleds

[Krzysztof Kozlowski]

On 31/08/2022 11:02, Martin Kepplinger wrote:
> From: Guido Günther <agx@xxxxxxxxxxx>
> 
> Describe the RGB notification leds on the Librem 5 phone.
> Use the common defines so we're sure to adhere to the common patterns,
> use predefined led colors and functions so we're being warned in case
> of deprecations.
> 
> Signed-off-by: Guido Günther <agx@xxxxxxxxxxx>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@xxxxxxx>
> ---
>  .../boot/dts/freescale/imx8mq-librem5.dtsi    | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index 0626e4194d958..bbf49e419b498 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -7,6 +7,7 @@
>  
>  #include "dt-bindings/input/input.h"
>  #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/leds/common.h>
>  #include "dt-bindings/pwm/pwm.h"
>  #include "dt-bindings/usb/pd.h"
>  #include "imx8mq.dtsi"
> @@ -54,6 +55,31 @@ key-vol-up {
>  		};
>  	};
>  
> +	pwmleds {
> +		compatible = "pwm-leds";
> +
> +		blue {

Test your DTS (`make dtbs_check`).

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation



Best regards,
Krzysztof