Re: [PATCH V2 1/8] dt-bindings: soc: imx: add binding for i.MX9 syscon

[Peng Fan]

On 8/31/2022 9:45 PM, Krzysztof Kozlowski wrote:
> On 31/08/2022 16:41, Peng Fan wrote:
> > On 8/31/2022 8:54 PM, Krzysztof Kozlowski wrote:
> > > On 31/08/2022 13:08, Peng Fan wrote:
> > > > On 8/31/2022 5:15 PM, Krzysztof Kozlowski wrote:
> > > > > On 31/08/2022 10:49, Peng Fan (OSS) wrote:
> > > > > > From: Peng Fan <peng.fan@xxxxxxx>
> > > > > >
> > > > > > Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
> > > > > >
> > > > > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > > > > > ---
> > > > > >     .../bindings/soc/imx/fsl,imx9-syscon.yaml     | 37 +++++++++++++++++++
> > > > > >     1 file changed, 37 insertions(+)
> > > > > >     create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> > > > > > new file mode 100644
> > > > > > index 000000000000..90c5e354f86c
> > > > > > --- /dev/null
> > > > > > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> > > > > > @@ -0,0 +1,37 @@
> > > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > > > > +%YAML 1.2
> > > > > > +---
> > > > > > +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#";
> > > > > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> > > > >
> > > > > One more - drop the quotes both lines above.
> > > >
> > > > There will be dtbs_check error. I updated schema with:
> > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@main
> > > >
> > > > So it is ok the drop the two quotes above? Is there
> > > > any new update in dt-schema that not landed in repo?
> > >
> > > This is something new to me, can you paste the error?
> >
> > I have renamed the file to "fsl,imx93-syscon.yaml"
> >
> > $DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml
> > make ARCH=arm64 DT_CHECKER_FLAGS=-m dtbs_check
> >
> >     LINT    Documentation/devicetree/bindings
> >     CHKDT   Documentation/devicetree/bindings/processed-schema.json
> > ./Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml: error
> > checking schema file
> >     SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>
> Hm, not much of an actual message. Most - or almost all - bindings do
> not have quotes, you know...
>
> This is something with your setup because above error is not reproducible.

I got something wrong in my side, my bad. It passes check now.

Thanks,
Peng.

> Best regards,
> Krzysztof