Re: [PATCH] ASoC: max98390: Remove unnecessary amp on/off conrtol
From: Mark Brown
Date: Wed Aug 31 2022 - 12:36:40 EST
On Fri, Aug 26, 2022 at 11:35:04AM +0900, Steve Lee wrote:
> The Amp is already control in userspace before trigger calibrate function.
> Remove unnecessary control in calibrate function.
I can't see anything which ensures that this is the case? Should there
be a check which returns an error if the output is not enabled, or
should the function check the current state and preserve it at the end?
I can see that this would fix problems with it being disabled when
callibrating.
Attachment:
signature.asc
Description: PGP signature