Re: [PATCH] platform/chrome: cros_ec_typec: Register partner PDOs

[Prashant Malani]

Thanks for the review, Heikki.

On Wed, Aug 31, 2022 at 1:45 AM Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
>
> On Tue, Aug 30, 2022 at 08:20:18PM +0000, Prashant Malani wrote:
> > The ChromeOS EC exports partner source/sink cap PDOs (Power Data
> > Objects) to the application processor (AP). Use this information
> > to register USB PD (Power Delivery) capabilities with the
> > USB Type-C Power Delivery device class.
> >
> > Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > Signed-off-by: Prashant Malani <pmalani@xxxxxxxxxxxx>
>
> This looks good to me. One nitpick below. With that fixed, FWIW:
>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>
> Will you later register also the port PDOs?
Yes, that is the plan.

> >       if (resp.events & PD_STATUS_EVENT_SOP_PRIME_DISC_DONE &&
> > @@ -1006,6 +1061,7 @@ static void cros_typec_handle_status(struct cros_typec_data *typec, int port_num
> >                                        "Failed SOP Disc event clear, port: %d\n", port_num);
> >               }
> >       }
> > +
> >  }
>
> I'm guessing that extra newline was just a typo.

Yeah ,I missed it during self-review :(
I'll fix it up while applying the patch if there is no other comment.
Otherwise I'll fix it in v2 (if there is one).