Re: [PATCH] Revert "iavf: Add waiting for response from PF in set mac"

From: Tony Nguyen
Date: Wed Aug 31 2022 - 14:36:46 EST


On 8/30/2022 2:43 PM, Petr Oros wrote:
This change caused a regressions with MAC address changing.
It is not possible to simple fix issues caused by this patch.
It is better revert/rework it.

[root@host ~]# ethtool -i enp65s0f0
driver: ice
version: 5.19.4-200.fc36.x86_64
firmware-version: 3.20 0x8000d83e 1.3146.0

- Change MAC for VF
[root@host ~]# echo 1 > /sys/class/net/enp65s0f0/device/sriov_numvfs
[root@host ~]# ip link set enp65s0f0v0 up
[root@host ~]# ip link set enp65s0f0v0 addr 00:11:22:33:44:55
RTNETLINK answers: Permission denied

- Add VF to bond
[root@host ~]# echo 2 > /sys/class/net/enp65s0f0/device/sriov_numvfs
[root@host ~]# ip link add bond0 type bond
[root@host ~]# ip link set enp65s0f0v0 down
[root@host ~]# ip link set enp65s0f0v1 down
[root@host ~]# ip link set enp65s0f0v0 master bond0
RTNETLINK answers: Permission denied
dmesg:
bond0: (slave enp65s0f0v1): Error -13 calling set_mac_address

This reverts commit 35a2443d0910fdd6ce29d4f724447ad7029e8f23.

Signed-off-by: Petr Oros <poros@xxxxxxxxxx>

Hi Petr,

Could you see if this patch [1] resolves your issues?

Thanks,
Tony

[1] https://lore.kernel.org/intel-wired-lan/20220831135243.8623-1-mateusz.palczewski@xxxxxxxxx/