Re: [PATCH v2 1/5] iio: adc: mcp320x: use callbacks for RX conversion

From: Andy Shevchenko
Date: Wed Aug 31 2022 - 16:22:28 EST


On Wed, Aug 31, 2022 at 5:19 PM Vincent Whitchurch
<vincent.whitchurch@xxxxxxxx> wrote:
> On Wed, Aug 31, 2022 at 02:40:49PM +0200, Andy Shevchenko wrote:
> > On Wed, Aug 31, 2022 at 1:05 PM Vincent Whitchurch
> > <vincent.whitchurch@xxxxxxxx> wrote:
> > > Replace the device_index switch with callbacks from the chip_info
> > > structure, so that the latter has all the information needed to handle
> > > the variants.
> >
> > Below are for the further patches, as I see the original code has the
> > same disadvantages.
>
> Right, these comments are in the original code that is either being just
> being moved or that even just happens to be in the context of the diff.
>
> Just to clarify, do you mean by "further patches" that you expect
> patches to fix these comments to be added to this series which adds
> triggered buffer support?

Yes.

--
With Best Regards,
Andy Shevchenko