Re: [PATCH] mm: remove BUG_ON() in __isolate_free_page()

From: David Hildenbrand
Date: Thu Sep 01 2022 - 03:38:12 EST


On 01.09.22 03:50, Kefeng Wang wrote:
> Drop unneed comment and blank, adjust the variable, and the most
> important is to delete BUG_ON(). The page passed is always buddy
> page into __isolate_free_page() from compaction, page_isolation
> and page_reporting, and the caller also check the return, BUG_ON()
> is a too drastic measure, remove it.

Why not WARN_ON_ONCE then? But yeah, maybe this really isn't of any
value anymore.

--
Thanks,

David / dhildenb