Re: [PATCH] ACPI: platform: Use PLATFORM_DEVID_NONE in acpi_create_platform_device()

From: Andy Shevchenko
Date: Thu Sep 01 2022 - 06:25:39 EST


On Thu, Sep 1, 2022 at 1:10 PM John Garry <john.garry@xxxxxxxxxx> wrote:
>
> Instead of hardcoding the value for the id, use PLATFORM_DEVID_NONE.

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
>
> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> index de3cbf152dee..d33334c9b8e5 100644
> --- a/drivers/acpi/acpi_platform.c
> +++ b/drivers/acpi/acpi_platform.c
> @@ -140,7 +140,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev,
> pdevinfo.parent = adev->parent ?
> acpi_get_first_physical_node(adev->parent) : NULL;
> pdevinfo.name = dev_name(&adev->dev);
> - pdevinfo.id = -1;
> + pdevinfo.id = PLATFORM_DEVID_NONE;
> pdevinfo.res = resources;
> pdevinfo.num_res = count;
> pdevinfo.fwnode = acpi_fwnode_handle(adev);
> --
> 2.35.3
>


--
With Best Regards,
Andy Shevchenko