Re: [PATCH linux-next] mmc: sdhci_am654: Remove the unneeded result variable

[Ulf Hansson]

On Tue, 30 Aug 2022 at 10:33, <cgel.zte@xxxxxxxxx> wrote:
>
> From: ye xingchen <ye.xingchen@xxxxxxxxxx>
>
> Return the value cqhci_init() directly instead of storing it in another
> redundant variable.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci_am654.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index e7ced1496a07..8f1023480e12 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -554,7 +554,6 @@ static const struct cqhci_host_ops sdhci_am654_cqhci_ops = {
>  static int sdhci_am654_cqe_add_host(struct sdhci_host *host)
>  {
>         struct cqhci_host *cq_host;
> -       int ret;
>
>         cq_host = devm_kzalloc(mmc_dev(host->mmc), sizeof(struct cqhci_host),
>                                GFP_KERNEL);
> @@ -568,9 +567,7 @@ static int sdhci_am654_cqe_add_host(struct sdhci_host *host)
>
>         host->mmc->caps2 |= MMC_CAP2_CQE;
>
> -       ret = cqhci_init(cq_host, host->mmc, 1);
> -
> -       return ret;
> +       return cqhci_init(cq_host, host->mmc, 1);
>  }
>
>  static int sdhci_am654_get_otap_delay(struct sdhci_host *host,
> --
> 2.25.1