Re: [PATCH v3 13/19] hwmon: (mr75203) modify the temperature equation according to series 5 datasheet

[Farber, Eliav]

On 8/31/2022 3:06 PM, Andy Shevchenko wrote:
> On Tue, Aug 30, 2022 at 07:22:06PM +0000, Eliav Farber wrote:
> > Modify the equation and coefficients used to convert the digital output
> > to temperature according to series 5 of the Moortec Embedded Temperature
> > Sensor (METS) datasheet:
> > T = G + H * (n / cal5 - 0.5) + J * F
> >
> > Where:
> > *) G = 60, H = 200, cal5 = 4094, J = -0.1.
> > *) F = frequency clock in MHz.
> > *) n is the digital output.
> >
> > In code, the G, H and J coefficients are multiplied by a factor of 1000
> > to get the temperature in milli-Celsius.
> > Final result is clamped in case it exceeds min/max thresholds.
> >
> > Change is done since it is not clear where the current equation and
>
> not clear -> unclear
Fixed.

> > coefficients came from.
>
> ...
>
> > +#define PVT_TEMP_MIN         -40000
> > +#define PVT_TEMP_MAX         125000
>
> Unit suffix? _mC perhaps would be enough.

Fixed. Added _mC suffix as you suggested.

--
Thanks, Eliav