Re: [PATCH v1 2/3] regmap: trace: Remove explicit castings

From: Mark Brown
Date: Thu Sep 01 2022 - 10:50:30 EST


On Thu, Sep 01, 2022 at 10:46:01AM -0400, Steven Rostedt wrote:
> Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> > Perhaps that (dark) magic disappeared a long time ago since in my
> > practice of adding trace events this is the first (and probably
> > oldest) one which has these castings. Perhaps Steven can shed a light.

> There was no dark magic for those castings. The trace events never needed
> them. It was added from the original commit:

> fb2736bbaee0e ("regmap: Add basic tracepoints")

Right, they were added in the original commit because as far as I could
tell at that time they were needed for things to build (or possibly
build cleanly, it's been a while).

Attachment: signature.asc
Description: PGP signature