Re: [PATCH 1/2] arm64: dts: qcom: sc7280: Add device tree for herobrine evoker

[Doug Anderson]

Hi,

On Thu, Sep 1, 2022 at 3:01 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 01/09/2022 12:12, Sheng-Liang Pan wrote:
> > Add a basic device tree for the herobrine evoker board.
> >
> > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> > ---
>
> And this is third v1? At least this is what your subject is suggesting.
> Patches should be properly versioned. Git format-patch helps in that,
> but you can use any other tools if you wish.

Just to make it clear, what Krzysztof is pointing at is the subject
line of your email. Based on your email headers it looks like you're
using "patman" to send out your emails. That means you can get what
Krzysztof wants by putting a "Series-version" in one of your patches.
Given that you had three v1 posts, maybe call the next version "v4"?
That means that one of the patches should have:

Series-version: 4

Then in each patch you'll have details about what changed in each
version. I guess we could sorta call the one where you added the
bindings "v2". So in the bindings patch you could add:

Series-changes: 2
- Bindings patch added

...and in both patches you could add:

Series-changes: 4
- Got the version number correct


You've already got a cover letter setup, so in that you should attempt
to explain some of this mess, like saying:

Sorry about getting mixed up with version numbers. Here are links to
previous postings and what I'll assume the version number is:

v1: https://lore.kernel.org/r/20220830053307.3997495-1-sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
v2: https://lore.kernel.org/r/20220901061336.61386-1-sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
v3: https://lore.kernel.org/r/20220901091253.93333-1-sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/


As an extra note: the bindings patch should be patch #1 and the device
tree should be patch #2. That means you should reorder your patches.

-Doug

>
> I pointed you to documentation you must read before posting. You can
> keep ignoring it, so we keep ignoring your patch.
>
> That's a NAK :(
>
> Best regards,
> Krzysztof