Re: [PATCH v2 4/4] RISC-V: Enable PMEM drivers

[Conor.Dooley]

On 30/08/2022 05:46, Anup Patel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> We now have PMEM arch support available in RISC-V kernel so let us
> enable relevant drivers in defconfig.
> 
> Co-developed-by: Mayuresh Chitale <mchitale@xxxxxxxxxxxxxxxx>
> Signed-off-by: Mayuresh Chitale <mchitale@xxxxxxxxxxxxxxxx>
> Signed-off-by: Anup Patel <apatel@xxxxxxxxxxxxxxxx>

Bunch of new build time warnings related to pmem w/ this patch
but they all seem to be problems in the nvdimm core code that've
just been exposed here...

Here's another name to add to your single-line defconfig change:
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

> ---
>  arch/riscv/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index aed332a9d4ea..010b673ebd11 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -159,6 +159,7 @@ CONFIG_VIRTIO_MMIO=y
>  CONFIG_RPMSG_CHAR=y
>  CONFIG_RPMSG_CTRL=y
>  CONFIG_RPMSG_VIRTIO=y
> +CONFIG_LIBNVDIMM=y
>  CONFIG_EXT4_FS=y
>  CONFIG_EXT4_FS_POSIX_ACL=y
>  CONFIG_EXT4_FS_SECURITY=y
> --
> 2.34.1
>