Re: [PATCH v12 12/13] dm: introduce DM_EMULATED_ZONES target type

From: Mike Snitzer
Date: Thu Sep 01 2022 - 20:29:10 EST


On Tue, Aug 23 2022 at 8:18P -0400,
Pankaj Raghav <p.raghav@xxxxxxxxxxx> wrote:

> Introduce a new target type DM_EMULATED_ZONES for targets with
> a different number of sectors per zone (aka zone size) than the underlying
> device zone size.
>
> This target type is introduced as the existing zoned targets assume
> that the target and the underlying device have the same zone size.
> The new target: dm-po2zone will use this new target
> type as it emulates the zone boundary that is different from the
> underlying zoned device.
>
> Signed-off-by: Pankaj Raghav <p.raghav@xxxxxxxxxxx>
> Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>

This patch's use of "target type" jargon isn't valid.

Please say "target feature flag" and rename DM_EMULATED_ZONES to
DM_TARGET_EMULATED_ZONES in the subject and header.

But, with those fixed:

Signed-off-by: Mike Snitzer <snitzer@xxxxxxxxxx>

(fyi, I'll review patch 13, the dm-po2zone target, tomorrow)