Re: [PATCH] mm/vmalloc: Extend find_vmap_lowest_match_check with extra arguments

[Baoquan He]

On 09/01/22 at 02:16pm, Uladzislau Rezki wrote:
> This is only for debug purpose.
> 
> Even without this patch, the debug path would work correctly. The
> difference is just only in
> whether roots are hardcoded or passed over function paramter.

Calling find_vmap_lowest_match() inside find_vmap_lowest_match_check()
will fail compilation because the function interface has been changed.

> 
> On Thu, Sep 1, 2022 at 2:47 AM Song Liu <song@xxxxxxxxxx> wrote:
> >
> > On Wed, Aug 31, 2022 at 4:01 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > On Tue, 30 Aug 2022 22:27:34 -0700 Song Liu <song@xxxxxxxxxx> wrote:
> > >
> > > > find_vmap_lowest_match() is now able to handle different roots. Make
> > > > similar changes to find_vmap_lowest_match_check() and
> > > > find_vmap_lowest_linear_match() to handle different trees.
> > >
> > > What are the runtime effects of this change?
> >
> > The code is gated by DEBUG_AUGMENT_LOWEST_MATCH_CHECK. It
> > is only compiled when the developer enables it explicitly. Therefore,
> > there isn't
> > any runtime effect.
> >
> > Thanks,
> > Song
> 
> 
> 
> -- 
> Uladzislau Rezki
>