Re: [PATCH v2 1/3] tty: serial: introduce transmit helper generators

[Jiri Slaby]

On 01. 09. 22, 14:25, Greg KH wrote:
> Much nicer, but:
>
> > +#define __DEFINE_UART_PORT_TX_HELPER(name, port, ch, tx_ready, put_char,  \
> > +		tx_done, for_test, for_post, ...)			  \
>
> Do you really need "port" and "ch" as part of this macro?  You always
> set that to the same thing in your patches, so is it really needed?

Not really, just to make obvious that those are the names that can be 
used in tx_ready, put_char... I can remove it, if you prefer, of course.

thanks,
--
js
suse labs