Re: [PATCH net-next v3 4/5] net: altera: tse: convert to phylink

From: Maxime Chevallier
Date: Fri Sep 02 2022 - 03:58:26 EST


Hello Jakub,

On Thu, 1 Sep 2022 21:10:21 -0700
Jakub Kicinski <kuba@xxxxxxxxxx> wrote:

> On Thu, 1 Sep 2022 16:35:42 +0200 Maxime Chevallier wrote:
> > This commit converts the Altera Triple Speed Ethernet Controller to
> > phylink. This controller supports MII, GMII and RGMII with its MAC,
> > and SGMII + 1000BaseX through a small embedded PCS.
> >
> > The PCS itself has a register set very similar to what is found in a
> > typical 802.3 ethernet PHY, but this register set memory-mapped
> > instead of lying on an mdio bus.
>
> allmodconfig builds report:
>
> ERROR: modpost: missing MODULE_LICENSE() in
> drivers/net/pcs/pcs-altera-tse.o

Ah you're right, I forgot to specify it. I'll address that in the next
version, thanks !

Maxime