Re: [PATCH -next 1/2] crypto: api - Fix IS_ERR() vs NULL check
From: Herbert Xu
Date: Fri Sep 02 2022 - 06:25:57 EST
On Thu, Aug 25, 2022 at 09:10:49PM +0800, cuigaosheng wrote:
> Thanks for taking the time to review this patch.
>
> crypto_alloc_test_larval() will return null if manager is disabled,
> it will not return error pointers, IS_ERR should not be used to checking
> return value, should we fix it? or use another solution?
That's because NULL is returned indicating success. When a genuine
error occurs then an error pointer will be returned. IS_ERR will be
true only in case of a genuine error. It will be false when either
NULL or a real larval pointer is returned.
You need to describe your problem more clearly as I have no idea what
you're trying to fix.
Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt