Re: [PATCH 0/4] PCI: mvebu: Add support for error interrupt

[Gregory CLEMENT]

Pali Rohár <pali@xxxxxxxxxx> writes:

> PCI mvebu error interrupt source is triggered for non-INTx event.
> So e.g. when AER or PME event occurs.
>
> This patch series adds support for reporting AER and PME interrupts on
> Marvell PCIe Root Ports which allows use to kernel AER and PME drivers.
>
> Without this change kernel AER and PME drivers do not work at all.
>
> DT bindings for this support is currently provided only for Kirkwood and
> Dove platforms as other new mvebu SoCs requires extension to armada IRQ
> driver, which is currently disallowed.
>
> Without new DTS files, pci-mvebu.c driver acts as before this change,
> there is no AER and PME kernel support.
>
> I have tested this change on Armada 385 board (with additional changes
> to A385 DTS files and IRQ driver, not included there) and AER interrupt
> is delivered to kernel AER driver correctly.
>
> Pali Rohár (4):
>   dt-bindings: PCI: mvebu: Update information about error interrupt
>   PCI: mvebu: Implement support for interrupts on emulated bridge


>   ARM: dts: kirkwood: Add definitions for PCIe error interrupts
>   ARM: dts: dove: Add definitions for PCIe error interrupts

Applied both dts patches on mvebu/dt

Thanks,

Gregory


>
>  .../devicetree/bindings/pci/mvebu-pci.txt     |   1 +
>  arch/arm/boot/dts/dove.dtsi                   |   8 +-
>  arch/arm/boot/dts/kirkwood-6192.dtsi          |   4 +-
>  arch/arm/boot/dts/kirkwood-6281.dtsi          |   4 +-
>  arch/arm/boot/dts/kirkwood-6282.dtsi          |   8 +-
>  arch/arm/boot/dts/kirkwood-98dx4122.dtsi      |   4 +-
>  drivers/pci/controller/pci-mvebu.c            | 256 ++++++++++++++++--
>  7 files changed, 252 insertions(+), 33 deletions(-)
>
> -- 
> 2.20.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com