Re: [PATCH v2 08/59] x86/build: Ensure proper function alignment

From: Linus Torvalds
Date: Fri Sep 02 2022 - 14:10:13 EST


On Fri, Sep 2, 2022 at 10:32 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> There is a DEBUG case that increases the thing to 32.

Well, but that should be part of the Kconfig rules too.

In fact, I think that argues for moving that FUNCTION_ALIGNMENT into
the generic Kconfig, since we already have that much hackier debug
thing there.

That would then get rid of the conditional in asm-generic too, and get
rid of the horrid hack in the main Makefile as well.

I love how commit cf536e185869 ("Makefile: extend 32B aligned debug
option to 64B aligned") took that previous random debug entry and just
made it 64B instead of 32B. What a crock that all is.

Let's just do this right.

Linus


Linus