Re: [PATCH v3] arm64: mte: move register initialization to C
From: kernel test robot
Date: Sun Sep 04 2022 - 09:07:08 EST
Hi Evgenii,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on linus/master v6.0-rc3 next-20220901]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Evgenii-Stepanov/arm64-mte-move-register-initialization-to-C/20220902-052059
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-randconfig-c033-20220904 (https://download.01.org/0day-ci/archive/20220904/202209042051.7ivKujfl-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/23927b7e78758b39d3463ae0a79b6b1af8fdef8b
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Evgenii-Stepanov/arm64-mte-move-register-initialization-to-C/20220902-052059
git checkout 23927b7e78758b39d3463ae0a79b6b1af8fdef8b
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/kernel/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
arch/arm64/kernel/suspend.c:34:13: warning: no previous prototype for 'cpu_suspend_set_dbg_restorer' [-Wmissing-prototypes]
34 | void __init cpu_suspend_set_dbg_restorer(int (*hw_bp_restore)(unsigned int))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/suspend.c: In function '__cpu_suspend_exit':
>> arch/arm64/kernel/suspend.c:46:9: error: implicit declaration of function 'mte_suspend_exit'; did you mean 'mte_suspend_enter'? [-Werror=implicit-function-declaration]
46 | mte_suspend_exit();
| ^~~~~~~~~~~~~~~~
| mte_suspend_enter
cc1: some warnings being treated as errors
vim +46 arch/arm64/kernel/suspend.c
41
42 void notrace __cpu_suspend_exit(void)
43 {
44 unsigned int cpu = smp_processor_id();
45
> 46 mte_suspend_exit();
47
48 /*
49 * We are resuming from reset with the idmap active in TTBR0_EL1.
50 * We must uninstall the idmap and restore the expected MMU
51 * state before we can possibly return to userspace.
52 */
53 cpu_uninstall_idmap();
54
55 /* Restore CnP bit in TTBR1_EL1 */
56 if (system_supports_cnp())
57 cpu_replace_ttbr1(lm_alias(swapper_pg_dir), idmap_pg_dir);
58
59 /*
60 * PSTATE was not saved over suspend/resume, re-enable any detected
61 * features that might not have been set correctly.
62 */
63 __uaccess_enable_hw_pan();
64
65 /*
66 * Restore HW breakpoint registers to sane values
67 * before debug exceptions are possibly reenabled
68 * by cpu_suspend()s local_daif_restore() call.
69 */
70 if (hw_breakpoint_restore)
71 hw_breakpoint_restore(cpu);
72
73 /*
74 * On resume, firmware implementing dynamic mitigation will
75 * have turned the mitigation on. If the user has forcefully
76 * disabled it, make sure their wishes are obeyed.
77 */
78 spectre_v4_enable_mitigation(NULL);
79
80 /* Restore additional feature-specific configuration */
81 ptrauth_suspend_exit();
82 }
83
--
0-DAY CI Kernel Test Service
https://01.org/lkp