Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: Remove reg entry for pmc8280c_lpg node

[Bhupesh Sharma]

On 9/5/22 12:08 PM, Krzysztof Kozlowski wrote:
> On 05/09/2022 08:47, Bhupesh Sharma wrote:
> > Hi Krzysztof,
> >
> > On 9/5/22 12:52 AM, Krzysztof Kozlowski wrote:
> > > On 03/09/2022 11:44, Bhupesh Sharma wrote:
> > > > Commit eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration")
> > > > dropped PWM reg declaration for pm8350c pwm(s), but there is a leftover
> > > > 'reg' entry inside the lpg/pwm node in sc8280xp dts file. Remove the same.
> > > >
> > > > While at it, also remove the unused unit address in the node
> > > > label.
> > > >
> > > > Fixes: eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration")
> > > > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > > > Cc: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > > > Cc: Bjorn Andersson <andersson@xxxxxxxxxx>
> > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>
> > > > ---
> > > >    arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 3 +--
> > > >    1 file changed, 1 insertion(+), 2 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> > > > index ae90b97aecb8..2e5cf55afdd5 100644
> > > > --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> > > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> > > > @@ -60,9 +60,8 @@ pmc8280c_gpios: gpio@8800 {
> > > >    			#interrupt-cells = <2>;
> > > >    		};
> > > >    
> > > > -		pmc8280c_lpg: lpg@e800 {
> > > > +		pmc8280c_lpg: lpg {
> > >
> > > I wonder why I did not see the errors when testing all DTSes for
> > > https://lore.kernel.org/all/20220828084341.112146-9-krzysztof.kozlowski@xxxxxxxxxx/
> >
> > I did not see the error while running the 'make dtbs_check' locally, so
> > may be something to improve in 'make dtbs_check' infrastructure there.
> >
> > > Anyway, it cannot be lpg - binding requires "pwm".
> >
> > I think that should be a separate patch. It does not seem related to
> > this change anyways - which fixes eeca7d46217c . I will send a v2 soon.
>
> You would be changing same line twice and eeca7d46217c is not going to
> be backported, so I am no sure if there is benefit to make two patches.

Ok. v2 sent accordingly 
(https://lore.kernel.org/linux-arm-msm/20220905070240.1634997-1-bhupesh.sharma@xxxxxxxxxx/)

Please help review.

Thanks.