Re: [PATCH] drm/print: cleanup coding style in drm_print.h

From: Jani Nikula
Date: Mon Sep 05 2022 - 04:49:56 EST


On Mon, 05 Sep 2022, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote:
> On Mon, 05 Sep 2022, Jingyu Wang <jingyuwang_vip@xxxxxxx> wrote:
>> Fix everything checkpatch.pl complained about in drm_print.h

[...]

>> static inline void
>> -drm_vprintf(struct drm_printer *p, const char *fmt, va_list *va)
>> +drm_vprintf(struct drm_printer *p, const char *fmt, va_list * va)
>
> Checkpatch is just confused here. Look at all the other params, why
> would you add an extra space here?

Joe, can you help me out here please, I can't figure out why checkpatch
is complaining here:

include/drm/drm_print.h:106: CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#106: FILE: include/drm/drm_print.h:106:
+drm_vprintf(struct drm_printer *p, const char *fmt, va_list *va)


BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center