Re: [PATCH v2 2/3] mm, page_owner: Add page_owner_stacks file to print out only stacks and their counter

From: kernel test robot
Date: Mon Sep 05 2022 - 18:21:07 EST


Hi Oscar,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.0-rc4]
[cannot apply to akpm-mm/mm-everything next-20220901]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Oscar-Salvador/page_owner-print-stacks-and-their-counter/20220905-111139
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7e18e42e4b280c85b76967a9106a13ca61c16179
config: microblaze-randconfig-m041-20220905 (https://download.01.org/0day-ci/archive/20220906/202209060655.H9CK1KgC-lkp@xxxxxxxxx/config)
compiler: microblaze-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

smatch warnings:
lib/stackdepot.c:586 stack_depot_print_stacks_threshold() warn: unsigned 'stack->size' is never less than zero.

vim +586 lib/stackdepot.c

568
569 int stack_depot_print_stacks_threshold(char *buf, size_t size, loff_t *pos)
570 {
571 int i = *pos, ret = 0;
572 struct stack_record **stacks, *stack;
573 static struct stack_record *last = NULL;
574 unsigned long stack_table_entries = stack_hash_mask + 1;
575
576 /* Continue from the last stack if we have one */
577 if (last) {
578 stack = last->next;
579 } else {
580 new_table:
581 stacks = &stack_table[i];
582 stack = (struct stack_record *)stacks;
583 }
584
585 for (; stack; stack = stack->next) {
> 586 if (!stack->size || stack->size < 0 ||

--
0-DAY CI Kernel Test Service
https://01.org/lkp