Re: [PATCH v1 1/1] pinctr: microchip-sgpio: Correct the fwnode_irq_get() return value check

From: Michael Walle
Date: Mon Sep 05 2022 - 18:24:50 EST

Next message: John Hubbard: "Re: [PATCH v9 1/8] mm: introduce FOLL_PCI_P2PDMA to gate getting PCI P2PDMA pages"
Previous message: kernel test robot: "[avpatel:riscv_kvm_aia_v1 38/41] arch/riscv/kvm/aia_aplic.c:264:6: warning: variable 'inject' is used uninitialized whenever 'if' condition is true"
In reply to: Andy Shevchenko: "[PATCH v1 1/1] pinctr: microchip-sgpio: Correct the fwnode_irq_get() return value check"
Next in thread: Andy Shevchenko: "Re: [PATCH v1 1/1] pinctr: microchip-sgpio: Correct the fwnode_irq_get() return value check"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Am 2022-09-05 21:08, schrieb Andy Shevchenko:

fwnode_irq_get() may return all possible signed values, such as Linux
error code. Fix the code to handle this properly.

Fixes: be2dc859abd4 ("pinctrl: pinctrl-microchip-sgpio: Add irq
support (for sparx5)")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Reviewed-by: Michael Walle <michael@xxxxxxxx>

Btw. do we care about EPROBE_DEFER?

-michael

Next message: John Hubbard: "Re: [PATCH v9 1/8] mm: introduce FOLL_PCI_P2PDMA to gate getting PCI P2PDMA pages"
Previous message: kernel test robot: "[avpatel:riscv_kvm_aia_v1 38/41] arch/riscv/kvm/aia_aplic.c:264:6: warning: variable 'inject' is used uninitialized whenever 'if' condition is true"
In reply to: Andy Shevchenko: "[PATCH v1 1/1] pinctr: microchip-sgpio: Correct the fwnode_irq_get() return value check"
Next in thread: Andy Shevchenko: "Re: [PATCH v1 1/1] pinctr: microchip-sgpio: Correct the fwnode_irq_get() return value check"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]