Re: [PATCH v12 2/3] phy: qcom-snps: Add support for overriding phy tuning parameters

[Krishna Kurapati PSSNV]

On 9/6/2022 8:15 AM, Bjorn Andersson wrote:
> On Sat, Sep 03, 2022 at 04:00:47PM +0530, Krishna Kurapati wrote:
> [..]
> > +static void qcom_snps_hsphy_read_override_param_seq(struct device *dev)
> > +{
> > +	struct device_node *node = dev->of_node;
> > +	s32 val;
> > +	int ret, i;
> > +	struct qcom_snps_hsphy *hsphy;
> > +	const struct override_param_map *cfg = of_device_get_match_data(dev);
>
> Given that you don't have any .data specified for the other compatibles
> (which is fine), cfg would be NULL here and below loop would attempt to
> access NULL[0].prop_name and crash.
>
> Please add a check for !cfg and just return here.
>
> With that I think the series looks good.
>
> Regards,
> Bjorn
My bad. Missed this before. Thanks for pointing it out.
Will push updated changes.

Thanks,
Krishna,