Re: [PATCH v11] dt-bindings: misc: fastrpc convert bindings to yaml

[Abel Vesa]

On 22-09-06 18:12:51, Krzysztof Kozlowski wrote:
> On 06/09/2022 17:01, Abel Vesa wrote:
> > Convert Qualcomm FastRPC bindings to yaml format, so that we could validate
> > dt-entries correctly and any future additions can go into yaml format.
> > 
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> > +
> > +patternProperties:
> > +  "(compute-)?cb@[0-9]*$":
> > +    type: object
> > +
> > +    description: >
> > +      Each subnode of the Fastrpc represents compute context banks available on the dsp.
> > +
> > +    properties:
> > +      compatible:
> > +        const: qcom,fastrpc-compute-cb
> > +
> > +      reg:
> > +        maxItems: 1
> > +
> > +      qcom,nsession:
> > +        $ref: /schemas/types.yaml#/definitions/uint32
> > +        default: 1
> > +        description: >
> > +          A value indicating how many sessions can share this context bank.
> > +
> > +    required:
> > +      - compatible
> > +      - reg
> 
> I think this was pointed previously by Rob in v4 - you need here
> additionalProperties: false (on that level of indentation).

Ugh, I thought if the check doesn't complain, it is not necessary to add
it as false.

Will resend.

> 
> > +
> > +required:
> > +  - compatible
> > +  - label
> > +  - "#address-cells"
> > +  - "#size-cells"
> > +
> 
> 
> Best regards,
> Krzysztof