Re: [PATCH -next v3 2/2] mm: sysctl: Introduce per zone watermark_scale_factor

[mawupeng]

On 2022/9/7 2:23, Luis Chamberlain wrote:
> On Mon, Sep 05, 2022 at 11:28:58AM +0800, Wupeng Ma wrote:
>> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
>> index 205d605cacc5..d16d06c71e5a 100644
>> --- a/kernel/sysctl.c
>> +++ b/kernel/sysctl.c
>> @@ -2251,8 +2251,6 @@ static struct ctl_table vm_table[] = {
>>  		.maxlen		= sizeof(watermark_scale_factor),
>>  		.mode		= 0644,
>>  		.proc_handler	= watermark_scale_factor_sysctl_handler,
>> -		.extra1		= SYSCTL_ONE,
>> -		.extra2		= SYSCTL_THREE_THOUSAND,
>>  	},
>>  	{
>>  		.procname	= "percpu_pagelist_high_fraction",
> 
> Please move the sysctl from kernel/sysctl.c to mm/page_alloc.c while
> at it, you can git log the kernel/sysctl.c for prior moves and for
> the motivations. No need to keep expanding on the existing table.
> 
>   Luis

Ok.

I will move this sysctl to mm/page_alloc.c next version.