Re: [PATCH] Documentation/process/magic-number.rst: kill

From: Bagas Sanjaya
Date: Tue Sep 06 2022 - 23:51:15 EST


On 9/6/22 07:38, наб wrote:
> The entire file blames back to the start of git
> (minus whitespace from the RST translation and a typo fix)
>
> There are changelog comments for March 1994 through to Linux 2.5.74,
> struct tty_ldisc is two pointers nowadays, so naturally no magic,
> GDA_MAGIC is defined but unused, and it's been this way
> since start-of-git,
> M3_CARD_MAGIC isn't defined, because
> commit d56b9b9c464a10ab1ee51a4c6190a2b57b8ef7a6 ("[PATCH] The scheduled
> removal of some OSS drivers") removed the entire driver in 2006,
> CS_CARD_MAGIC likewise since
> commit b5d425c97f7d4e92151167b01ca038e7853c6b37 ("more scheduled OSS
> driver removal") in 2007,
> KMALLOC_MAGIC and VMALLOC_MAGIC got killed in
> commit e38e0cfa48ac38f4fe24453d2523852467c95b21 ("[ALSA] Remove kmalloc
> wrappers"), six months after start of git,
> SLAB_C_MAGIC has never appeared in git (killed in 2.4.0-test3pre6).
>

Seems like incomprehensible to me. Did you mean comparing pre-git era
changelog to current doc?

Also, the subject line should be "Documentation: remove magic number doc".

Thanks.

--
An old man doll... just what I always wanted! - Clara