Re: [PATCH] perf: Consolidate branch sample filter helpers

From: Anshuman Khandual
Date: Wed Sep 07 2022 - 02:22:06 EST




On 9/6/22 15:39, Peter Zijlstra wrote:
> On Tue, Sep 06, 2022 at 02:14:14PM +0530, Anshuman Khandual wrote:
>> Besides the branch type filtering requests, 'event.attr.branch_sample_type'
>> also contains various flags indicating which additional information should
>> be captured, along with the base branch record. These flags help configure
>> the underlying hardware, and capture the branch records appropriately when
>> required e.g after PMU interrupt. But first, this moves an existing helper
>> perf_sample_save_hw_index() into the header before adding some more helpers
>> for other branch sample filter flags.
>>
>> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
>> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>> Cc: linux-perf-users@xxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
>> ---
>> Hello Peter,
>>
>> Could you please consider taking this patch along with others on the perf
>> ABI series. This patch has been part of the original BRBE driver series,
>> which will have one less patch to include going forward. Thank you.
>>
>> - Anshuman
>>
>> This applies on v6.0-rc4 but after applying the following patch series
>>
>> https://lore.kernel.org/all/20220824044822.70230-1-anshuman.khandual@xxxxxxx/
>>
>
> Yeah, but it doesn't cleanly apply to tip/perf/core....
>
> The conflict looks trivial, let me stomp on it to make it fit :-)

Thank you.