Re: [REGRESSION 5.19.x] AMD HD-audio devices missing on 5.19

From: Jason Gunthorpe
Date: Wed Sep 07 2022 - 09:48:45 EST


On Wed, Sep 07, 2022 at 03:28:31PM +0200, Takashi Iwai wrote:
> > /**
> > * iommu_device_use_default_domain() - Device driver wants to handle device
> > * DMA through the kernel DMA API.
> > @@ -3094,8 +3112,7 @@ int iommu_device_use_default_domain(struct device *dev)
> >
> > mutex_lock(&group->mutex);
> > if (group->owner_cnt) {
> > - if (group->domain != group->default_domain ||
> > - group->owner) {
> > + if (group->owner || iommu_is_default_domain(group)) {
>
> Isn't this rather
> if (group->owner || !iommu_is_default_domain(group)) {
> ?
>
> I'll rebuild the kernel with this change and ask reporters again.

Oh yes, good eyes, that probably crashes on boot too

Jason