Re: [v7 13/14] iio: imu: add BNO055 I2C driver

[Andy Shevchenko]

On Wed, Sep 7, 2022 at 4:22 PM <andrea.merello@xxxxxx> wrote:
>
> From: Andrea Merello <andrea.merello@xxxxxx>
>
> Add an I2C driver for communicating to a BNO055 IMU via I2C bus and enable
> the BNO055 core driver to work in this scenario.
>
> Signed-off-by: Andrea Merello <andrea.merello@xxxxxx>

> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Hmm... It has my tag but I have noticed something to improve.

...

> +#define BNO055_I2C_XFER_BURST_BREAK_THRESHOLD 3 /* FIXME */

Can we elaborate what to fix and why it can't be fixed right now?

...

> +static const struct of_device_id __maybe_unused bno055_i2c_of_match[] = {
> +       { .compatible = "bosch,bno055" },

> +       { },

No comma for the terminator entry.

> +};

...

> +               .of_match_table = of_match_ptr(bno055_i2c_of_match),

No of_match_ptr(). This will disable ACPI support along with potential
compiler warning.

-- 
With Best Regards,
Andy Shevchenko