Re: [PATCH 2/2] objtool, kcsan: Add volatile read/write instrumentation to whitelist
From: Marco Elver
Date: Wed Sep 07 2022 - 13:48:03 EST
On Wed, 7 Sept 2022 at 19:45, Boqun Feng <boqun.feng@xxxxxxxxx> wrote:
>
> On Wed, Sep 07, 2022 at 07:43:32PM +0200, Marco Elver wrote:
> > On Wed, 7 Sept 2022 at 19:42, Boqun Feng <boqun.feng@xxxxxxxxx> wrote:
> > >
> > > On Wed, Sep 07, 2022 at 07:39:03PM +0200, Marco Elver wrote:
> > > > Adds KCSAN's volatile barrier instrumentation to objtool's uaccess
> > >
> > > Confused. Are things like "__tsan_volatile_read4" considered as
> > > "barrier" for KCSAN?
> >
> > No, it's what's emitted for READ_ONCE() and WRITE_ONCE().
> >
>
> Thanks for clarification, then I guess better to remove the word
> "barrier" in the commit log?
Yes, that'd be best. (I think it was a copy/paste error.)
Thanks,
-- Marco