RE: [PATCH v5 5/8] EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes

[Justin He]

Hi Kani

> -----Original Message-----
> From: Kani, Toshi <toshi.kani@xxxxxxx>
> Sent: Thursday, September 8, 2022 8:31 AM
> To: Justin He <Justin.He@xxxxxxx>; Len Brown <lenb@xxxxxxxxxx>; James
> Morse <James.Morse@xxxxxxx>; Tony Luck <tony.luck@xxxxxxxxx>; Borislav
> Petkov <bp@xxxxxxxxx>; Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>;
> Robert Richter <rric@xxxxxxxxxx>; Robert Moore <robert.moore@xxxxxxxxx>;
> Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>; Yazen Ghannam
> <yazen.ghannam@xxxxxxx>; Jan Luebbe <jlu@xxxxxxxxxxxxxx>; Khuong
> Dinh <khuong@xxxxxxxxxxxxxxxxxxxxxx>
> Cc: Ard Biesheuvel <ardb@xxxxxxxxxx>; linux-acpi@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linux-edac@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx;
> Rafael J . Wysocki <rafael@xxxxxxxxxx>; Shuai Xue
> <xueshuai@xxxxxxxxxxxxxxxxx>; Jarkko Sakkinen <jarkko@xxxxxxxxxx>;
> linux-efi@xxxxxxxxxxxxxxx; nd <nd@xxxxxxx>
> Subject: RE: [PATCH v5 5/8] EDAC/ghes: Make ghes_edac a proper module to
> remove the dependency on ghes
> 
> On Monday, September 5, 2022 9:25 AM, Jia He wrote:
> > -void ghes_edac_unregister(struct ghes *ghes)
> > +static void ghes_edac_unregister(struct ghes *ghes)
> >  {
> >  	struct mem_ctl_info *mci;
> >  	unsigned long flags;
> >
> > -	if (!ghes_edac_force_enable)
> > -		return;
> > -
> 
> I am not familiar with this original check.  Assuming it is safe to delete it now
> (as you mentioned in other email w/o description), I suggest adding some
> description to the commit log.
> 
Thanks, will do
I've tested the insmod/rmmod multiple times on Arm host.

I will wait for others' comments for a while before sending the new version.
> At high-level, the patch looks good to me.
> Acked-by: Toshi Kani <toshi.kani@xxxxxxx>

Thanks a lot for the help 😊

--
Cheers,
Justin (Jia He)