RE: [PATCH -next v2 5/5] misc: microchip: pci1xxxx: use module_auxiliary_driver

From: Kumaravel.Thiagarajan
Date: Thu Sep 08 2022 - 02:16:41 EST


> -----Original Message-----
> From: Wei Yongjun <weiyongjun@xxxxxxxxxxxxxxx>
> Sent: Wednesday, September 7, 2022 8:28 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@xxxxxxxxxxxxx>; Arnd Bergmann
> <arnd@xxxxxxxx>; Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Wei Yongjun <weiyongjun1@xxxxxxxxxx>; linux-gpio@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH -next v2 5/5] misc: microchip: pci1xxxx: use
> module_auxiliary_driver
>
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> Use the module_auxiliary_driver() macro to make the code simpler by
> eliminating module_init and module_exit calls.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
Fixes: 7d3e4d807df2 ("misc: microchip: pci1xxxx: load gpio driver for the gpio controller auxiliary device enumerated by the auxiliary bus driver.")

Reviewed-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@xxxxxxxxxxxxx>

> ---
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> index fa80a7788596..9cc771c604ed 100644
> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> @@ -421,19 +421,7 @@ static struct auxiliary_driver pci1xxxx_gpio_driver = {
> .probe = pci1xxxx_gpio_probe,
> .id_table = pci1xxxx_gpio_auxiliary_id_table };
> -
> -static int __init pci1xxxx_gpio_driver_init(void) -{
> - return auxiliary_driver_register(&pci1xxxx_gpio_driver);
> -}
> -
> -static void __exit pci1xxxx_gpio_driver_exit(void) -{
> - auxiliary_driver_unregister(&pci1xxxx_gpio_driver);
> -}
> -
> -module_init(pci1xxxx_gpio_driver_init);
> -module_exit(pci1xxxx_gpio_driver_exit);
> +module_auxiliary_driver(pci1xxxx_gpio_driver);
>
> MODULE_DESCRIPTION("Microchip Technology Inc. PCI1xxxx GPIO
> controller"); MODULE_AUTHOR("Kumaravel Thiagarajan
> <kumaravel.thiagarajan@xxxxxxxxxxxxx>");
> --
> 2.34.1