Re: [PATCH] perf lock: Remove redundant word 'contention' in help message

[Namhyung Kim]

Hello,

On Wed, Sep 7, 2022 at 6:52 PM Yang Jihong <yangjihong1@xxxxxxxxxx> wrote:
>
> Before:
>   # perf lock -h
>
>    Usage: perf lock [<options>] {record|report|script|info|contention|contention}
>
>       -D, --dump-raw-trace  dump raw trace in ASCII
>       -f, --force           don't complain, do it
>       -i, --input <file>    input file name
>       -v, --verbose         be more verbose (show symbol address, etc)
>           --kallsyms <file>
>                             kallsyms pathname
>           --vmlinux <file>  vmlinux pathname
>
> After:
>   # perf lock -h
>
>    Usage: perf lock [<options>] {record|report|script|info|contention}
>
>       -D, --dump-raw-trace  dump raw trace in ASCII
>       -f, --force           don't complain, do it
>       -i, --input <file>    input file name
>       -v, --verbose         be more verbose (show symbol address, etc)
>           --kallsyms <file>
>                             kallsyms pathname
>           --vmlinux <file>  vmlinux pathname
>
> Fixes: 528b9cab3b81 ("perf lock: Add 'contention' subcommand")
> Signed-off-by: Yang Jihong <yangjihong1@xxxxxxxxxx>

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks for the fix!

Namhyung


> ---
>  tools/perf/builtin-lock.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index dd11d3471baf..ea40ae52cd2c 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -1874,8 +1874,7 @@ int cmd_lock(int argc, const char **argv)
>                 NULL
>         };
>         const char *const lock_subcommands[] = { "record", "report", "script",
> -                                                "info", "contention",
> -                                                "contention", NULL };
> +                                                "info", "contention", NULL };
>         const char *lock_usage[] = {
>                 NULL,
>                 NULL
> --
> 2.30.GIT
>