Re: [PATCH 1/4 v2] dt-bindings: memory: Factor out common properties of LPDDR bindings
From: Krzysztof Kozlowski
Date: Thu Sep 08 2022 - 10:01:26 EST
On 08/09/2022 01:29, Julius Werner wrote:
> The bindings for different LPDDR versions mostly use the same kinds of
> properties, so in order to reduce duplication when we're adding support
> for more versions, this patch creates a new lpddr-props subschema that
> can be referenced by the others to define these common parts. (This will
> consider a few smaller I/O width and density numbers "legal" for LPDDR3
> that are usually not used there, but this should be harmless.)
>
> Signed-off-by: Julius Werner <jwerner@xxxxxxxxxxxx>
> ---
> .../ddr/jedec,lpddr-props.yaml | 52 +++++++++++++++++++
> .../memory-controllers/ddr/jedec,lpddr2.yaml | 40 ++------------
> .../memory-controllers/ddr/jedec,lpddr3.yaml | 32 ++----------
> 3 files changed, 60 insertions(+), 64 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr-props.yaml
>
> Changelog:
>
> - v2:
> - removed minItems
> - reordered io-width enum from lowest to highest
> - moved `$ref` below `mainainers`
> - removed part about undeprecating manufacturer-id
Looks good for me. With Rob's ack (for this or for v3) I'll take it via
memory controllers.
Best regards,
Krzysztof