Re: [RFC-PATCH] Makefile: dts: include directory makefile for DTC_FLAGS
From: Daniel Walker
Date: Thu Sep 08 2022 - 10:39:53 EST
On Thu, Sep 08, 2022 at 04:08:06PM +0900, Masahiro Yamada wrote:
> On Thu, Sep 8, 2022 at 8:03 AM Daniel Walker <danielwa@xxxxxxxxx> wrote:
> >
> > The current Makefile will drop the DTC_FLAGS depending on how you
> > build. For example,
> >
> > make dtbs
> >
> > includes correct DTC_FLAGS. However if you run,
> >
> > make nvidia/tegra210-p2371-2180.dtb
> >
> > The DTC_FLAGS are dropped. This appears to be caused by the top level
> > Makefile not including the Makefile from the directory where the dts lives.
> >
> > This normally doesn't matter because most dts files have nothing added
> > from the Makefile. This changes when you have overlays, and the
> > DTC_FLAGS modifier is mandatory for the dtb to work correctly.
>
>
> I recently fixed another issue of single target builds.
> https://patchwork.kernel.org/project/linux-kbuild/patch/20220906061313.1445810-2-masahiroy@xxxxxxxxxx/
>
>
> It fixed your issue as well.
>
>
Yeah, it fixes the issue I was seeing. Are you planning to resubmit this or is
the v2 the final version ?
Daniel