Re: [PATCH] security/keys: Remove inconsistent __user annotation

[Paul Moore]

On Thu, Sep 8, 2022 at 1:17 AM Jarkko Sakkinen <jarkko@xxxxxxxxxx> wrote:
> On Wed, Sep 07, 2022 at 11:43:17AM -0400, Paul Moore wrote:
> > On Wed, Sep 7, 2022 at 10:06 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> > > On 9/7/22 05:12, Vincenzo Frascino wrote:
> > > > The declaration of keyring_read does not match the definition
> > > > (security/keys/keyring.c). In this case the definition is correct
> > > > because it matches what defined in "struct key_type::read"
> > > > (linux/key-type.h).
> > > >
> > > > Fix the declaration removing the inconsistent __user annotation.
> > > >
> > > > Cc: David Howells <dhowells@xxxxxxxxxx>
> > > > Cc: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
> > > > Cc: Paul Moore <paul@xxxxxxxxxxxxxx>
> > > > Cc: James Morris <jmorris@xxxxxxxxx>
> > > > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>
> > > > ---
> > > > Note: This issue was discovered during the porting of the linux kernel
> > > > on Morello [1].
> > > >
> > > > [1] https://git.morello-project.org/morello/kernel/linux
> > >
> > > FTR, I have sent this same patch 3 times.
> > > Good luck.
> >
> > David or Jarkko, this patch is both trivial and obviously correct,
> > please merge this into the keys tree for the next merge window else
> > I'll take it via the LSM tree.
> >
> > Reviewed-by: Paul Moore <paul@xxxxxxxxxxxxxx>
>
> I picked it to my tree.

Thanks Jarkko.

-- 
paul-moore.com