Re: [PATCH] net: ipv4: Fix some coding style in ah4.c file

From: Andrew Lunn
Date: Thu Sep 08 2022 - 16:26:17 EST


> @@ -165,7 +165,8 @@ static int ah_output(struct xfrm_state *x, struct sk_buff *skb)
> ahp = x->data;
> ahash = ahp->ahash;
>
> - if ((err = skb_cow_data(skb, 0, &trailer)) < 0)
> + err = skb_cow_data(skb, 0, &trailer));

I prefer the coding style issue over it not compiling at all.

I suggest you don't embarrass yourself any more by compile testing
your changes.

Andrew