Re: [V1 PATCH 1/5] selftests: kvm: move common startup logic to kvm_util.c

From: David Matlack
Date: Thu Sep 08 2022 - 17:09:57 EST


On Sat, Sep 03, 2022 at 01:28:45AM +0000, Vishal Annapurve wrote:
[...]
> --- a/tools/testing/selftests/kvm/demand_paging_test.c
> +++ b/tools/testing/selftests/kvm/demand_paging_test.c
> @@ -393,7 +393,7 @@ static void help(char *name)
> exit(0);
> }
>
> -int main(int argc, char *argv[])
> +void __main(int argc, char *argv[])
> {
> int max_vcpus = kvm_check_cap(KVM_CAP_MAX_VCPUS);
> struct test_params p = {
> @@ -447,18 +447,15 @@ int main(int argc, char *argv[])
> }
>
> for_each_guest_mode(run_test, &p);
> -
> - return 0;
> }
>
> #else /* __NR_userfaultfd */
>
> #warning "missing __NR_userfaultfd definition"
>
> -int main(void)
> +void __main(int argc, char *argv[])
> {
> print_skip("__NR_userfaultfd must be present for userfaultfd test");
> - return KSFT_SKIP;

exit(KSFT_SKIP) to preserve the test behavior.